Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutableType moved to SpiNNMan #1048

Merged
merged 7 commits into from
Apr 24, 2023
Merged

ExecutableType moved to SpiNNMan #1048

merged 7 commits into from
Apr 24, 2023

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Apr 20, 2023

Create a stub to allow the moved ExecutableType to still be imported from FrontendCommon

See: SpiNNakerManchester/SpiNNMan#323

@Christian-B
Copy link
Member Author

Using only the stud from spinn_front_end_common.utilities.utility_objs import ExecutableType
http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/move_ExecutableType/1/pipeline

@rowleya
Copy link
Member

rowleya commented Apr 20, 2023

Warning: the warning might occur even when you don't directly import the class.

If this isn't the case, it might be easier to just do "from spinnman.model.enums import ExecutableType", which will immediately make it available here.

@Christian-B
Copy link
Member Author

Warning: the warning might occur even when you don't directly import the class.

If this isn't the case, it might be easier to just do "from spinnman.model.enums import ExecutableType", which will immediately make it available here.

Agreed removed.

@rowleya rowleya merged commit e85be3b into master Apr 24, 2023
@rowleya rowleya deleted the move_ExecutableType branch April 24, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants