Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiver ping #1034

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Receiver ping #1034

merged 4 commits into from
Mar 24, 2023

Conversation

rowleya
Copy link
Member

@rowleya rowleya commented Mar 23, 2023

Makes it possible for an external receiver sitting behind a firewall to continuously receive packets. This is done by repeatedly setting the tag (once every 10 seconds) which keeps the firewall port open.

@rowleya rowleya added the enhancement This adds a new feature label Mar 23, 2023
Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - I was just wondering whether you'd used 10 seconds based on some testing, or if that was the first thing you tried?

@rowleya
Copy link
Member Author

rowleya commented Mar 24, 2023

I suspect 10 seconds to be more often than needed; it runs for a few minutes without issue then suddenly stops without this, so I figured 10 seconds was plenty!

@andrewgait andrewgait merged commit 69579f6 into master Mar 24, 2023
@andrewgait andrewgait deleted the push_bot_viewer branch March 24, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants