Ds sqlite per reset which requires data generation #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2022
# Conflicts: # spinn_front_end_common/interface/interface_functions/graph_data_specification_writer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1015
In Master there is one DS.sqlite3 file per hard reset.
On a soft reset with requires_data_generation the previous rows are deleted from the database and new rows added.
In this pr a new sqlite3 file is created instead with the old one kept.
This makes it more consistent with other files not overridden or cleared after a reset
This would make it easier to compare what has changed between 1 reset and another.
Must be done at the same time as:
SpiNNakerManchester/JavaSpiNNaker#713
Check all ds files exist added in (to be merged)
SpiNNakerManchester/sPyNNaker#1243
Tested by: (no need to merge)
SpiNNakerManchester/IntegrationTests#164