hide Placements #453
Merged
hide Placements #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2022
andrewgait
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chain of Prs. Hides the Placements Object inside the view offering only Semantic sugar methods which avoids anyone editing the Placements.
Documented by:
SpiNNakerManchester/SpiNNakerManchester.github.io#43
There are several places where a chain of loops over placements methods could be replaced by a single new method.
A few unused methods that used placements have been removed.
Part of SpiNNakerManchester/SpiNNFrontEndCommon#954
But does not full fix it as that will be done by moving the asb buts that add placements together.
Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#965
SpiNNakerManchester/sPyNNaker#1206
SpiNNakerManchester/SpiNNakerGraphFrontEnd#219
tested by:
SpiNNakerManchester/IntegrationTests#125