-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create graph #450
Merged
Merged
Create graph #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2022
andrewgait
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, just a few minor edits suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #449
An ApplicationGraph is now created during the Writer.setup or mock call. So except for before sim.setup (or unittest_setup())
there is always a graph so no need to call create graph or set_(runtime)_ graph
The Graph Class (or at least what was actually needed) has been merged into ApplicationGraph.
With the following changes
(This has a minor cost that you can not iterate vertices and add at the same time)
As the Graph is never cloned the clone method has been removed.
As the Graph is never given to the use the ApplicationGraphView is no longer need
Must be done after:
SpiNNakerManchester/SpiNNUtils#184
Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#961
SpiNNakerManchester/sPyNNaker#1202
SpiNNakerManchester/SpiNNakerGraphFrontEnd#217
tested by
http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/create_graph/3/pipeline
Documented by
SpiNNakerManchester/SpiNNakerManchester.github.io#42