VDX-76 #1
Merged
VDX-76 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklomp
requested changes
Aug 4, 2022
…rt of function params
nklomp
requested changes
Aug 5, 2022
lib/utils/index.ts
Outdated
| if (response.status >= 400) { | ||
| return Promise.reject(Error(`Unable to retrieve did configuration resource from ${url}`)) | ||
| } | ||
| return response.json(); |
There was a problem hiding this comment.
Yeah, but I typically like to have logic which is so close to object part of that object to prevent bugs. Maybe change it into a method that accepts a boolean to do the check and that defaults to true, so that you can disable it if you want.
nklomp
approved these changes
Aug 5, 2022
nklomp
approved these changes
Aug 8, 2022
nklomp
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.