VDX-88 #54
VDX-88 #54
Conversation
|
plugin.schema.json is supplied as we cannot let it generate one as callbacks are being used |
|
the build failing is because of a test in the ms-authenticator that takes to long to complete |
packages/wellknown-did-verifier/__tests__/shared/wellKnownDidVerifierAgentLogic.ts
Outdated
Show resolved
Hide resolved
packages/wellknown-did-verifier/src/types/IWellKnownDidVerifier.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| export interface IRegisterSignatureVerificationArgs { | ||
| key: string |
There was a problem hiding this comment.
Can we change the name. This might be confusing with did private/public keys
There was a problem hiding this comment.
See other remarks. It can still be confused with a public key for signature verification. Suggest to name it to something like callbackName, which makes immediate sense to a developer
| @@ -24,12 +20,12 @@ export interface IWellKnownDidVerifierOptionsArgs { | |||
| } | |||
|
|
|||
| export interface IRegisterSignatureVerificationArgs { | |||
| key: string | |||
| signatureVerificationKey: string | |||
There was a problem hiding this comment.
callbackName might be better, because this can still be confused with a public key for signature verification
| signatureVerification: (args: IVerifyCallbackArgs) => Promise<IVerifyCredentialResult> | ||
| } | ||
|
|
||
| export interface IRemoveSignatureVerificationArgs { | ||
| key: string | ||
| signatureVerificationKey: string |
There was a problem hiding this comment.
callbackName might be better, because this can still be confused with a public key for signature verification
No description provided.