Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wal 246 ION DID Provider #53

Merged
merged 18 commits into from
Aug 12, 2022
Merged

Feature/wal 246 ION DID Provider #53

merged 18 commits into from
Aug 12, 2022

Conversation

nklomp
Copy link
Contributor

@nklomp nklomp commented Aug 10, 2022

Implement ION DID Provider. Seeking initial feedback before rebasing to Veramo and opening a PR there.

Changes:

  • Remove old ION provider code
  • Do not depend on ion-tools
  • Do not depend on external POW SDK. An improved version is part of the code. We might extract that into a seperate lib at one point
  • Update and recovery keys, including key rotations
  • Full implementation of all Identifier methods

Known issues:

  • POW works on Node. Not tested yet on React-native. Out of scope for this implementation
  • Adding/Updating services/keys does not get propagated. Needs more investigation. MS gives back a 200 response for them, but it never ends up in the DID Document. Will look at that later.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #53 (db658c8) into develop (040014a) will decrease coverage by 0.59%.
The diff coverage is 61.13%.

@@             Coverage Diff             @@
##           develop      #53      +/-   ##
===========================================
- Coverage    62.73%   62.13%   -0.60%     
===========================================
  Files           23       55      +32     
  Lines          864     1833     +969     
  Branches       173      339     +166     
===========================================
+ Hits           542     1139     +597     
- Misses         322      694     +372     
Impacted Files Coverage Δ
...ages/bls-did-provider-key/src/BlsKeyDidProvider.ts 0.00% <0.00%> (ø)
...ages/bls-did-provider-key/src/BlsKeyDidResolver.ts 0.00% <0.00%> (ø)
.../connection-manager/src/agent/ConnectionManager.ts 0.00% <0.00%> (ø)
...ction-manager/src/store/AbstractConnectionStore.ts 0.00% <0.00%> (ø)
...on/src/migrations/internal-migrations-ormconfig.ts 0.00% <0.00%> (ø)
...kages/data-store/src/connection/ConnectionStore.ts 0.00% <0.00%> (ø)
...uth-siop-op-authenticator/src/session/OpSession.ts 5.30% <0.00%> (-1.01%) ⬇️
...er/src/migrations/internal-migrations-ormconfig.ts 0.00% <0.00%> (ø)
packages/ms-request-api/src/agent/MsRequestApi.ts 0.00% <0.00%> (ø)
...ges/vc-handler-ld-local/src/ld-default-contexts.ts 100.00% <ø> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@BtencateSphereon BtencateSphereon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nklomp nklomp merged commit 1a07d3d into develop Aug 12, 2022
@nklomp nklomp deleted the feature/WAL-246 branch August 12, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants