Feature/from funke #241
Merged
Feature/from funke #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # packages/credential-store/package.json # packages/data-store/package.json # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/pd-manager/package.json # packages/presentation-exchange/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/ssi-types/src/mapper/credential-mapper.ts # pnpm-lock.yaml
…ture/from-funke # Conflicts: # packages/oid4vci-issuer/package.json # packages/oid4vci-issuer/src/functions.ts # packages/w3c-vc-api/package.json # pnpm-lock.yaml
sanderPostma
commented
Sep 24, 2024
| break | ||
| case 'x5c': | ||
| if (isManagedIdentifierResult(identifier) && isManagedIdentifierX5cResult(identifier)) { | ||
| return [CredentialCorrelationType.X509_SAN, identifier.x5c.join('\r\n')] |
There was a problem hiding this comment.
@nklomp not sure about this one
# Conflicts: # packages/presentation-exchange/src/functions.ts # packages/sd-jwt/src/action-handler.ts # packages/siopv2-oid4vp-op-auth/src/session/OID4VP.ts
fix/SPRIND-60
…source/ssi-sdk into feature/from-funke # Conflicts: # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json
nklomp
approved these changes
Oct 1, 2024
| "allowBranch": [ | ||
| "main", | ||
| "master", | ||
| "feature/from-funke" |
| type SupportedAlgorithms = (typeof supportedAlgorithms)[number] | ||
|
|
||
| // FIXME this is a weird place for this, but it does have good reach in ssi-sdk cunlike the copy in oid4vc-common | ||
| export const defaultHasher: Hasher = (data, algorithm) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT FINISHED