feature/SDK-24 #225
feature/SDK-24 #225
Conversation
…orted by postgres
packages/credential-store/__tests__/shared/credentialStoreAgentLogic.ts
Outdated
Show resolved
Hide resolved
| * @param withFilter - Optional additional filter criteria. | ||
| * @returns A FindDigitalCredentialArgs array for filtering verifiable credentials by role. | ||
| */ | ||
| export const verifiableCredentialForRoleFilter = ( |
There was a problem hiding this comment.
Why is this only available for VCs? We need this for C, VP, P as well, as all of these can have roles
There was a problem hiding this comment.
This is just a helper to avoid duplicate code and make it easier to fetch only VC's
If you need one of the other document types, don't use "verifiableCredentialForRoleFilter"
Create your own filter or create a verifiablePresentationForRoleFilter function when having duplicate code.
| const digitalCredentials = await this.crsGetUniqueCredentials({ | ||
| filter: [ | ||
| { | ||
| documentType: DocumentType.VC, // TODO does crmGetCredentialsByClaims need to support VPs as well? |
There was a problem hiding this comment.
At least C should be supported, but a ticket should be created to indeed also support (V)P
# Conflicts: # packages/ebsi-support/src/agent/EbsiSupport.ts # packages/siopv2-oid4vp-op-auth/src/session/OID4VP.ts
# Conflicts: # packages/ms-request-api/package.json # packages/siopv2-oid4vp-op-auth/src/services/Siopv2MachineService.ts # pnpm-lock.yaml
# Conflicts: # packages/oid4vci-holder/src/agent/OID4VCIHolder.ts
| @@ -634,7 +634,7 @@ export class OID4VCIHolder implements IAgentPlugin { | |||
| }) | |||
|
|
|||
| const credential = { | |||
| id: issuanceOpt.credentialConfigurationId ?? issuanceOpt.id, | |||
| id: (issuanceOpt.credentialConfigurationId ?? issuanceOpt.id) as string | undefined, // cast due to error: Type 'unknown' is not assignable to type 'string | undefined'. | |||
There was a problem hiding this comment.
| id: (issuanceOpt.credentialConfigurationId ?? issuanceOpt.id) as string | undefined, // cast due to error: Type 'unknown' is not assignable to type 'string | undefined'. | |
| id: (issuanceOpt.credentialConfigurationId ?? issuanceOpt.id as string | undefined), // cast due to error: Type 'unknown' is not assignable to type 'string | undefined'. |
There was a problem hiding this comment.
I just pulled in something very recent from develop where id is determined a few lines up, so let's see if that builds
There was a problem hiding this comment.
Well the bigger question is why it fails. I know that the lower level libs have some changes. But that has been fixed in develop. The fact develop builds and this branch doesn't suggest either the PR is reverting something, not using the latest develop, or new code is introduced where this happens. Please investigate first before continuing @sanderPostma
There was a problem hiding this comment.
Ah okay, now I understand what you mean. Yes this was fixed in lates develop
There was a problem hiding this comment.
@nklomp
Looks like build are passing now indeed
No description provided.