-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/CWALL-153 #171
feature/CWALL-153 #171
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #171 +/- ##
===========================================
+ Coverage 33.72% 36.41% +2.68%
===========================================
Files 157 183 +26
Lines 7884 9474 +1590
Branches 1884 2129 +245
===========================================
+ Hits 2659 3450 +791
- Misses 5223 6022 +799
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed to be able to extend contacts/individuals with metadata like on the party level. We are not creating a student product. To add student entities make no sense, and was not wat was discussed during sprint start
packages/contact-manager/__tests__/shared/contactManagerAgentLogic.ts
Outdated
Show resolved
Hide resolved
…re/CWALL-153 # Conflicts: # packages/contact-manager/__tests__/shared/contactManagerAgentLogic.ts # packages/data-store/src/__tests__/contact.entities.test.ts # packages/data-store/src/__tests__/contact.store.test.ts # packages/data-store/src/entities/contact/IdentityEntity.ts # packages/data-store/src/entities/contact/PartyTypeEntity.ts # packages/data-store/src/types/contact/contact.ts # packages/oid4vci-holder/src/agent/OID4VCIHolder.ts
…ource/ssi-sdk into feature/CWALL-153 # Conflicts: # packages/contact-manager/__tests__/shared/contactManagerAgentLogic.ts
tests are failing |
…re/CWALL-153 # Conflicts: # pnpm-lock.yaml
No description provided.