Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/CWALL-153 #171

Merged
merged 40 commits into from
Jun 7, 2024
Merged

feature/CWALL-153 #171

merged 40 commits into from
Jun 7, 2024

Conversation

zoemaas
Copy link
Contributor

@zoemaas zoemaas commented Mar 19, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 48.97119% with 248 lines in your changes are missing coverage. Please review.

Project coverage is 36.41%. Comparing base (5303341) to head (c4d749c).
Report is 222 commits behind head on develop.

Current head c4d749c differs from pull request most recent head 28a0d20

Please upload reports for the commit 28a0d20 to get more accurate results.

Files Patch % Lines
...igrations/postgres/1710438363001-CreateContacts.ts 2.08% 47 Missing ⚠️
...igrations/postgres/1690925872592-CreateContacts.ts 0.00% 37 Missing ⚠️
.../migrations/sqlite/1690925872693-CreateContacts.ts 0.00% 36 Missing ⚠️
...a-store/src/migrations/generic/8-CreateContacts.ts 39.13% 28 Missing ⚠️
...a-store/src/migrations/generic/9-CreateContacts.ts 39.13% 28 Missing ⚠️
.../migrations/sqlite/1710438363002-CreateContacts.ts 48.88% 23 Missing ⚠️
...kages/data-store/src/utils/contact/MappingUtils.ts 78.26% 20 Missing ⚠️
...igrations/postgres/1715761125001-CreateContacts.ts 7.14% 13 Missing ⚠️
packages/data-store/src/contact/ContactStore.ts 81.13% 10 Missing ⚠️
.../migrations/sqlite/1715761125002-CreateContacts.ts 57.14% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
+ Coverage    33.72%   36.41%   +2.68%     
===========================================
  Files          157      183      +26     
  Lines         7884     9474    +1590     
  Branches      1884     2129     +245     
===========================================
+ Hits          2659     3450     +791     
- Misses        5223     6022     +799     
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nklomp nklomp self-requested a review March 29, 2024 14:21
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed to be able to extend contacts/individuals with metadata like on the party level. We are not creating a student product. To add student entities make no sense, and was not wat was discussed during sprint start

…re/CWALL-153

# Conflicts:
#	packages/contact-manager/__tests__/shared/contactManagerAgentLogic.ts
#	packages/data-store/src/__tests__/contact.entities.test.ts
#	packages/data-store/src/__tests__/contact.store.test.ts
#	packages/data-store/src/entities/contact/IdentityEntity.ts
#	packages/data-store/src/entities/contact/PartyTypeEntity.ts
#	packages/data-store/src/types/contact/contact.ts
#	packages/oid4vci-holder/src/agent/OID4VCIHolder.ts
@sanderPostma sanderPostma marked this pull request as ready for review May 16, 2024 18:09
packages/contact-manager/src/agent/ContactManager.ts Outdated Show resolved Hide resolved
packages/data-store/src/__tests__/contact.entities.test.ts Outdated Show resolved Hide resolved
packages/data-store/src/contact/ContactStore.ts Outdated Show resolved Hide resolved
packages/data-store/src/contact/ContactStore.ts Outdated Show resolved Hide resolved
packages/data-store/src/index.ts Show resolved Hide resolved
packages/data-store/src/utils/contact/MappingUtils.ts Outdated Show resolved Hide resolved
packages/data-store/src/utils/contact/MappingUtils.ts Outdated Show resolved Hide resolved
packages/oid4vci-holder/src/agent/OID4VCIHolder.ts Outdated Show resolved Hide resolved
@BtencateSphereon
Copy link
Contributor

tests are failing

@sanderPostma sanderPostma merged commit 1684d5f into develop Jun 7, 2024
2 checks passed
@BtencateSphereon BtencateSphereon deleted the feature/CWALL-153 branch June 7, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants