Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added contact test data #126

Merged
merged 3 commits into from
Sep 15, 2023
Merged

feat: added contact test data #126

merged 3 commits into from
Sep 15, 2023

Conversation

sksadjad
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #126 (aaa98b9) into develop (ba38097) will decrease coverage by 11.67%.
Report is 613 commits behind head on develop.
The diff coverage is 56.25%.

❗ Current head aaa98b9 differs from pull request most recent head 2706a7e. Consider uploading reports for the commit 2706a7e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           develop     #126       +/-   ##
============================================
- Coverage    45.89%   34.22%   -11.67%     
============================================
  Files           65      139       +74     
  Lines         2412     6816     +4404     
  Branches       539     1530      +991     
============================================
+ Hits          1107     2333     +1226     
- Misses        1305     4482     +3177     
- Partials         0        1        +1     
Files Changed Coverage Δ
packages/agent-config/src/agentCreator.ts 0.00% <0.00%> (ø)
packages/agent-config/src/dataSources.ts 0.00% <0.00%> (ø)
packages/agent-config/src/objectCreator.ts 0.00% <0.00%> (ø)
...ages/contact-manager-rest-api/src/api-functions.ts 0.00% <0.00%> (ø)
...manager-rest-api/src/contact-manager-api-server.ts 0.00% <0.00%> (ø)
...ckages/contact-manager/src/agent/ContactManager.ts 0.00% <0.00%> (ø)
...re/src/migrations/internal-migrations-ormconfig.ts 0.00% <0.00%> (ø)
...es/issuance-branding/src/agent/IssuanceBranding.ts 0.00% <0.00%> (ø)
packages/kv-store/src/key-value-store.ts 78.18% <ø> (ø)
packages/kv-store/src/keyv/keyv.ts 73.10% <ø> (ø)
... and 53 more

... and 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these values more in line with what was used in the Web-walet so we have a bit of a feal what more realistic values look like in the ui

@sksadjad
Copy link
Contributor Author

@nklomp changed the test values to be inline with previous version of test data

@sksadjad sksadjad marked this pull request as ready for review September 14, 2023 07:24
@nklomp nklomp merged commit 4de2a64 into develop Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants