chore: added header to kbJwt

Sphereon-Opensource · Sep 17, 2024 · e2ad2de · e2ad2de
1 parent f6f9cac
commit e2ad2de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/oid4vci-holder/src/agent/OID4VCIHolder.ts b/packages/oid4vci-holder/src/agent/OID4VCIHolder.ts
@@ -787,8 +787,7 @@ export class OID4VCIHolder implements IAgentPlugin {
     if (!issuanceOpt || !issuanceOpt.identifier) {
       return Promise.reject(Error('issuanceOpt.identifier must me set in order to store a credential'))
     }
-    const identifier = issuanceOpt.identifier
-    const { kmsKeyRef, method } = identifier
+    const { kmsKeyRef, method } = issuanceOpt.identifier
 
     let persist = true
     const verifiableCredential = mappedCredentialToAccept.uniformVerifiableCredential as VerifiableCredential

diff --git a/packages/ssi-types/src/types/sd-jwt-vc.ts b/packages/ssi-types/src/types/sd-jwt-vc.ts
@@ -2,6 +2,7 @@ import { OriginalType, WrappedVerifiableCredential, WrappedVerifiablePresentatio
 import { decodeSdJwt, decodeSdJwtSync, getClaims, getClaimsSync } from '@sd-jwt/decode'
 import { CompactJWT, IVerifiableCredential } from './w3c-vc'
 import { IProofPurpose, IProofType } from './did'
+import { JWTHeader } from 'did-jwt'
 
 type JsonValue = string | number | boolean | { [x: string]: JsonValue | undefined } | Array<JsonValue>
 
@@ -123,8 +124,9 @@ export interface SdJwtDecodedVerifiableCredential {
    * Key binding JWT
    */
   kbJwt?: {
-    compact: CompactJWT
+    header: JWTHeader
     payload: SdJwtVcKbJwtPayload
+    compact?: CompactJWT
   }
 }
 
@@ -276,7 +278,7 @@ export async function decodeSdJwtVcAsync(compactSdJwtVc: CompactSdJwtVc, hasher:
 // TODO naive implementation of mapping a sd-jwt onto a IVerifiableCredential. Needs some fixes and further implementation and needs to be moved out of ssi-types
 export const sdJwtDecodedCredentialToUniformCredential = (
   decoded: SdJwtDecodedVerifiableCredential,
-  opts?: { maxTimeSkewInMS?: number },
+  opts?: { maxTimeSkewInMS?: number }
 ): IVerifiableCredential => {
   const { decodedPayload } = decoded // fixme: other params and proof
   const { exp, nbf, iss, iat, vct, cnf, status, sub, jti } = decodedPayload
@@ -292,7 +294,7 @@ export const sdJwtDecodedCredentialToUniformCredential = (
 
       return acc
     },
-    {},
+    {}
   )
 
   const maxSkewInMS = opts?.maxTimeSkewInMS ?? 1500