Skip to content

Commit

Permalink
refactor: changed the clientCredential parameter from credentialManif…
Browse files Browse the repository at this point in the history
…est to credentialManifestUrl
sksadjad committed Jun 22, 2022
1 parent 1dd418d commit dc693a2
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/ms-authenticator/__tests__/authenticators.test.ts
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ describe('@sphereon/ms-authenticator', () => {
azClientId: '04c2bd60-cdbf-4935-80dd-110fdf473e6e',
azClientSecret:'<YOUR_CCLIENT_SECRET>',
azTenantId: 'e2a42b2f-7460-4499-afc2-425315ef058a',
credentialManifest:'https://beta.eu.did.msidentity.com/v1.0/e2a42b2f-7460-4499-afc2-425315ef058a/verifiableCredential/contracts/VerifiedCredentialExpert2'
credentialManifestUrl:'https://beta.eu.did.msidentity.com/v1.0/e2a42b2f-7460-4499-afc2-425315ef058a/verifiableCredential/contracts/VerifiedCredentialExpert2'
})).resolves.not.toBeNull();
});

4 changes: 2 additions & 2 deletions packages/ms-authenticator/src/types/IMsAuthenticator.ts
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ import { IAgentContext } from '@veramo/core'
* azClientId: clientId of the application you're trying to login
* azClientSecret: secret of the application you're trying to login
* azTenantId: your MS Azure tenantId
* credentialManifest: address of your credential manifest. usually in following format:
* credentialManifestUrl: url of your credential manifest. usually in following format:
* https://beta.eu.did.msidentity.com/v1.0/<tenant_id>/verifiableCredential/contracts/<verifiable_credential_schema>
* authority: optional. if not provided, we'll use the azClientId to create the Tenanted format if provided should be one of these two formats:
* - Tenanted: https://login.microsoftonline.com/{tenant}/, where {tenant} is either the GUID representing the tenant ID or a domain name associated with the tenant.
@@ -16,7 +16,7 @@ export interface IMsAuthenticationClientCredentialArgs {
azClientId: string
azTenantId: string
azClientSecret: string
credentialManifest: string
credentialManifestUrl: string
authority?: string
scopes?: string[]
skipCache?: boolean

0 comments on commit dc693a2

Please sign in to comment.