fix: Incorrect verification method id returned when signing credentia…

…ls in some cases
Sphereon-Opensource · Jan 13, 2023 · bdbf4ef · bdbf4ef
1 parent c508507
commit bdbf4ef
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/vc-handler-ld-local/src/agent/CredentialHandlerLDLocal.ts b/packages/vc-handler-ld-local/src/agent/CredentialHandlerLDLocal.ts
@@ -107,8 +107,8 @@ export class CredentialHandlerLDLocal implements IAgentPlugin {
       return await this.ldCredentialModule.issueLDVerifiableCredential(
         credential,
         identifier.did,
-        managedKey || signingKey,
-        managedKey ? (verificationMethod as string) : verificationMethodId,
+        managedKey || signingKey, // todo: signingKey does not have the private key, so would never work
+        verificationMethodId ? verificationMethodId : (verificationMethod as string),
         args.purpose,
         context
       )
@@ -184,7 +184,7 @@ export class CredentialHandlerLDLocal implements IAgentPlugin {
       return await this.ldCredentialModule.signLDVerifiablePresentation(
         presentation,
         identifier.did,
-        signingKey || managedKey,
+        managedKey || signingKey, // todo: signingKey does not have the private key, so would never work
         verificationMethodId ? verificationMethodId : (verificationMethod as string),
         args.challenge,
         args.domain,