fix: await session state updates #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
|
It was on purpose, to ensure any calling code would not be blocking on the session management itself. But for now let's indeed await. It needs some refactoring, simplification anyway soon. |
nklomp
approved these changes
Mar 12, 2024
|
@TimoGlastra 0.10.1 has the fixes: https://github.com/Sphereon-Opensource/OID4VCI/releases/tag/v0.10.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some state updates (set, delete) were not awaited. When updating the in memory session manager to one that uses persistance storage we were running into issues were we would close our database session (as the call to this library is finished), but then a write would still happen as the updates to the session were not awaited.
Were these awaits left out on purpose?