Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the signing algorithm list in the credential issuance process #92

Conversation

vincentkelleher
Copy link

Open the Signing Algorithm List

As a reference to #88, this Pull Request allows developers to use the given Alg list or a signing algorithm of their choice by just checking that the alg field is provided without verifying if its value is part of the Alg enum.

Some tests have been re-enabled, added and modified to have some coverage on this part.

@sanderPostma
Copy link
Contributor

LGTM

@sanderPostma sanderPostma requested a review from nklomp February 21, 2024 13:58
@sanderPostma sanderPostma merged commit c0bd6b1 into Sphereon-Opensource:develop Feb 22, 2024
1 check passed
@vincentkelleher vincentkelleher deleted the feature/signing-algorithms branch February 23, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants