Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable awesome-qr in rn #87

Merged

Conversation

TimoGlastra
Copy link
Collaborator

We have a combined @credo-ts/openid4vc package that depends on the common, issuer and client libraires.

When importing this into react native it is giving us some issues because RN resolves conditional imports to bundle in the JS bundle and awesome-qr is an optional dependnecy.

We could add awesome-qr as a dependency and it'd then bundle awesome-qr with our app, but adding a react-native clause to the issuer package also solves the issue

It will limit the usage of creating a QR when creating an offer, but then someone will need to a) write an issuer in React Native and b) use the QR generation options. And even then is the question whether this package works in React Native.

It seemed like a valid workaround. But i can also just add the dependency to the bundle if you think we shouldn't do this

Signed-off-by: Timo Glastra <[email protected]>
@nklomp
Copy link
Contributor

nklomp commented Feb 12, 2024

For now it is unlikely that an issuer would be a RN application, although that could change of course for proximity use cases and other transports in the future. But yeah let's disable it

@nklomp nklomp merged commit 81adb47 into Sphereon-Opensource:develop Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants