Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a combined
@credo-ts/openid4vc
package that depends on the common, issuer and client libraires.When importing this into react native it is giving us some issues because RN resolves conditional imports to bundle in the JS bundle and awesome-qr is an optional dependnecy.
We could add awesome-qr as a dependency and it'd then bundle awesome-qr with our app, but adding a
react-native
clause to the issuer package also solves the issueIt will limit the usage of creating a QR when creating an offer, but then someone will need to a) write an issuer in React Native and b) use the QR generation options. And even then is the question whether this package works in React Native.
It seemed like a valid workaround. But i can also just add the dependency to the bundle if you think we shouldn't do this