Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
vc+sd-jwt
format as described in https://github.com/vcstuff/oid4vc-haip-sd-jwt-vcBecause the format specific for
vc+sd-jwt
are a bit different than the other formats, it exposed some issues with the types currently being used. I updated all interfaces, made the uniform interfaces match draft 11 fully, and moved some v8/9 specific types outside of the uniform/generic types.Because the types are different, and it exposed some issues with the current way requests are being made, there's more format speicfic logic now inline. I've didn't want to make this PR bigger than it currently is, so I've created a separate issue #76, to explore that work.
All tests are passing except the e2e test with mattr launchpad, as it's currently down for maintenance. In addition I had to change some tests with vendors, as the expected types do not match with the spec. They all hardcode that the version is draft 8, but then they use a format that is somewhere in between draft 8 and 9. Mabye that's what those vendors implemented, or maybe it was just a mock that was created? I don't know, but I've corrected them now.
I think if we also address #75 at the same time we address #76, it can clean up a lot of format specific code that's now spread across the repository