Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sd-jwt support #78

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

TimoGlastra
Copy link
Collaborator

Adds support for vc+sd-jwt format as described in https://github.com/vcstuff/oid4vc-haip-sd-jwt-vc

Because the format specific for vc+sd-jwt are a bit different than the other formats, it exposed some issues with the types currently being used. I updated all interfaces, made the uniform interfaces match draft 11 fully, and moved some v8/9 specific types outside of the uniform/generic types.

Because the types are different, and it exposed some issues with the current way requests are being made, there's more format speicfic logic now inline. I've didn't want to make this PR bigger than it currently is, so I've created a separate issue #76, to explore that work.

All tests are passing except the e2e test with mattr launchpad, as it's currently down for maintenance. In addition I had to change some tests with vendors, as the expected types do not match with the spec. They all hardcode that the version is draft 8, but then they use a format that is somewhere in between draft 8 and 9. Mabye that's what those vendors implemented, or maybe it was just a mock that was created? I don't know, but I've corrected them now.

I think if we also address #75 at the same time we address #76, it can clean up a lot of format specific code that's now spread across the repository

Signed-off-by: Timo Glastra <[email protected]>
@nklomp
Copy link
Contributor

nklomp commented Nov 16, 2023

Cool thanks, will have a look later today

@TimoGlastra
Copy link
Collaborator Author

FYI @nklomp, made a another PR that builds on top of this PR: TimoGlastra#1

But it needs a few tweaks before it's ready to be merged (need to get some input from my team on what the input looks like with SD-JWT VCs) as you need to provide some details about which fields can be disclosed, etc..

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one comment about a fixme, but IMO we should solve that anyway by ensuring we drop support for older versions, so it is a bit of a mute discussion anyway

@nklomp
Copy link
Contributor

nklomp commented Nov 23, 2023

Let's keep the version discussion for #75. Per approved and to be merged.

@nklomp nklomp merged commit 651c110 into Sphereon-Opensource:develop Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants