Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use JSON file extension on mathmaps files #536

Merged
merged 1 commit into from
Jun 23, 2021
Merged

use JSON file extension on mathmaps files #536

merged 1 commit into from
Jun 23, 2021

Conversation

ggrossetie
Copy link
Contributor

resolves #535

@ggrossetie ggrossetie marked this pull request as ready for review June 19, 2021 09:56
@ggrossetie ggrossetie mentioned this pull request Jun 19, 2021
Closed
@zorkow
Copy link
Member

zorkow commented Jun 23, 2021 •
edited
Loading

Many thanks for the PR. I really appreciate it.
Just a minor snag: I am in the process of merging the new Typescript version of SRE (PR #533 ) into which might cause conflicts with your PR.

Problems should should not be too difficult to resolve:

  • Makefile has shrunk and only deals with .json files now.
  • mathmaps have move to the top directory as src has gone.

I'll have a look before I merge PRs.

zorkow
zorkow approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

src/speech_rules/math_map.js
@@ -190,7 +190,7 @@ sre.MathMap.prototype.retrieveMaps = function(locale) {
return;
}
var file = sre.BaseUtil.makePath(sre.SystemExternal.jsonPath) +
locale + '.js';
locale + '.json';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to be moved manually to the TS version.

@zorkow zorkow merged commit 72cb579 into Speech-Rule-Engine:develop Jun 23, 2021
@ggrossetie
Copy link
Contributor Author

Thanks for your review and merge!
Feel free to ping me if if you have any questions 😉

@ggrossetie ggrossetie deleted the issue-535-use-json-extension branch June 23, 2021 19:48
@Znegl
Copy link

Znegl commented Oct 4, 2021

Do you know when this will be released?

@Znegl Znegl mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use json extension on mathmaps files
3 participants
@ggrossetie @zorkow @Znegl