Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Advantagekit and get Decorator logging working #6

Open
allengregoryiv opened this issue Nov 18, 2023 · 4 comments
Open

Update Advantagekit and get Decorator logging working #6

allengregoryiv opened this issue Nov 18, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request Needs Testing changes work in sim; need to be tested on robot

Comments

@allengregoryiv
Copy link
Member

The new advantagekit updates have decorator based logging that should be a lot cleaner to use.

https://www.chiefdelphi.com/t/advantagekit-2024-log-replay-again/442968/28

@Daniel-J101 Daniel-J101 added the enhancement New feature or request label Nov 18, 2023
@allengregoryiv
Copy link
Member Author

@Daniel-J101 I believe that your commit is correct, does it work in simulation?

@Daniel-J101
Copy link
Contributor

Yes it does appear to log them correctly in sim

@Daniel-J101
Copy link
Contributor

Daniel-J101 commented Nov 18, 2023

I only replaced the old Logger.recordOutputs with the decorator, is there anything else that should be added now?

@allengregoryiv
Copy link
Member Author

allengregoryiv commented Nov 18, 2023 via email

@Daniel-J101 Daniel-J101 added the WIP Work in Progress: still being written label Nov 19, 2023
@Daniel-J101 Daniel-J101 added Needs Testing changes work in sim; need to be tested on robot and removed WIP Work in Progress: still being written labels Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs Testing changes work in sim; need to be tested on robot
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants