Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negation matcher to hoverfly #1117

Merged

Conversation

kapishmalik
Copy link
Collaborator

resolves => #1101

@kapishmalik kapishmalik requested a review from tommysitu March 11, 2024 13:24
@tommysitu
Copy link
Member

Thanks, I will test it, is this how you use it?

{
   "matcher": "negate", 
   "value": "something else"
}

@kapishmalik
Copy link
Collaborator Author

Hey @tommysitu yes, that is way we can test it. I have added integration tests as well for reference. Also, I will add documentation once approach looks fine.

@kapishmalik kapishmalik self-assigned this Mar 12, 2024
Copy link
Member

@tommysitu tommysitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 👍

@tommysitu tommysitu merged commit d6ce5a0 into SpectoLabs:master Mar 13, 2024
3 checks passed
@kapishmalik kapishmalik deleted the add-negation-matcher-to-hoverfly branch March 14, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants