-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hoverctl not loading config.yaml on first start #704
Comments
hoverctl is loading config.yaml fine. I think the bug is to do with hoverctl removes |
Tommy,
Correct, it loads the config.yaml from the file if you do the config
before starting things up or doing a status. However, it wipes things out
when it starts up or does a status, which it shouldn't do. I don't think
the auth being enabled or disabled matters to wiping it out; however, it
does seem to reset it to disabled, i.e., false.
hoverfly@localhost ~/.hoverfly> hoverctl config
/opt/QL/app/hoverfly/.hoverfly/config.yaml
default: local
targets:
local:
name: local
host: localhost
admin.port: 8888
proxy.port: 8500
authenabled: true
username: "test"
password: "t3stm3!"
hoverfly@localhost ~/.hoverfly> hoverctl status
Could not connect to Hoverfly at localhost:8888
hoverfly@localhost ~/.hoverfly> hoverctl config
/opt/QL/app/hoverfly/.hoverfly/config.yaml
default: local
targets:
local:
name: local
host: localhost
admin.port: 8888
proxy.port: 8500
authenabled: false
username: ""
password: ""
hoverfly@localhost ~/.hoverfly>
…On Mon, Mar 12, 2018 at 5:55 AM, Tommy Situ ***@***.***> wrote:
hoverctl is loading config.yaml fine. I think the bug is to do with
hoverctl remove the username and password if auth is disabled.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#704 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ajd3ZDsNmYfbROLYQr4Fi6QH7Cgdl8mtks5tdkYAgaJpZM4SjFeW>
.
|
tommysitu
added a commit
that referenced
this issue
Jan 17, 2019
tommysitu
added a commit
that referenced
this issue
Jan 17, 2019
tommysitu
added a commit
that referenced
this issue
Jan 17, 2019
tommysitu
added a commit
that referenced
this issue
Jan 17, 2019
tommysitu
added a commit
that referenced
this issue
Jan 17, 2019
@jrtaisto thank you for reporting this issue. It was caused by hoverctl resetting optional fields when parsing the config file. Sorted in the upcoming RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ENV:
OS: CentOS 7
Running as non-root account
Version:
hoverfly@localhost ~> hoverctl version
+----------+----------+
| hoverctl | |
| hoverfly | v0.15.1 |
+----------+----------+
Conditions: Install bits for hoverfly, use pre-configured .hoverfly/config.yaml, and do the following:
hoverfly@localhost ~> hoverctl status
Could not connect to Hoverfly at localhost:8888
hoverfly@localhost ~> cat .hoverfly/config.yaml
default: local
targets:
local:
name: local
host: localhost
admin.port: 8888
proxy.port: 8500
authenabled: false
username: "test"
password: "test123"
hoverfly@localhost ~> hoverctl config
/home/hoverfly/.hoverfly/config.yaml
default: local
targets:
local:
name: local
host: localhost
admin.port: 8888
proxy.port: 8500
authenabled: false
username: "test"
password: "test123"
The above is expected. Put in a default username password but haven't enabled auth yet.
hoverfly@localhost ~> hoverctl status
Could not connect to Hoverfly at localhost:8888
hoverfly@localhost ~> hoverctl config
/home/hoverfly/.hoverfly/config.yaml
default: local
targets:
local:
name: local
host: localhost
admin.port: 8888
proxy.port: 8500
authenabled: false
username: ""
password: ""
Yikes!! Why the clean slate? I didn't use hoverctl or hoverfly to modify the local config, but yet it changed. It seems to do the same thing no matter what you do pertaining to hoverctl start|status|stop which doesn't make any sense. The config.yaml should be persistent and should only change if you're locally changing things with hoverctl/hoverfly or if you're managing this instance remotely via hoverctl.
The text was updated successfully, but these errors were encountered: