Cucumber expressions support #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on type and validity
|
@SabotageAndi The PR is finally getting closer to finish, so probably it is worth starting to review it. There are a few open points (you will see TODOs), that we should discuss and I will make some further exploratory testing. We should consider calling this v4.0 BTW -- but let's discuss this. |
|
@gasparnagy not sure I find time to have a look at this week. But next week should be possible. |
|
@SabotageAndi OK/thx. I am on a conf Thu-Fri. |
SabotageAndi
approved these changes
Jun 2, 2022
| @focus | ||
| Feature: Cucumber expressions | ||
|
|
||
| Rule: Shoud support Cucumber expressions |
There was a problem hiding this comment.
Typo, it should be Should
|
|
||
| return result.ToString(); | ||
|
|
||
| throw new NotImplementedException(); |
* origin/master: remove .NET Core 2.1 and .NET 5 support (#2611) # Conflicts: # ExternalRepositories/SpecFlow.TestProjectGenerator # TechTalk.SpecFlow/SpecFlow.nuspec
Code-Grump
pushed a commit
to Code-Grump/SpecFlow
that referenced
this pull request
Mar 29, 2023
* Add Cucumber.CucumberExpressions package dependency
* Refactor binding discovery to ise IStepDefinitionBindingBuilder
* Refactor StepDefinitionBinding to contain source expression, expression type and validity
* Fix unit tests
* Introduce CucumberExpressionStepDefinitionBindingBuilder
* Use IExpression on IStepDefinitionBinding
* small fix & ignore cukeex scenario
* Fix old project format tests
* Introduce step definition error handling
* Integrate Cucumber Expressions
* Force regex for Step Def
* Force regex for Step Def once more
* add tests
* enum support
* tests for custom type
* support for custom parameter names for StepArgumentTransformation
* try cleaning up string handling (not working)
* fix string handling?
* Add scenarios, fix [StepArgTrafo]
* fix unit test
* refactor RegexFactory
* provide cucumber expression step definition skeletons
* remove parameter type dumping
* Generate regex-based snippets in ^xxx$ style, cleanup
* Upgrade Cucumber.CucumberExpressions to v16.0.0
* allow overriding {int}, define: {double}, {decimal}, cleanup
* Cleanup {string} handling
* fix build?
* Add specflow-config.json
* update spec specflow-config.json wit cucumber expressions
* Add {byte}, {long}
* Check is [Obsolete] works
* Extend docs with Cucumber-Expressions
* Show upgrade guide link in binding error message.
* Remove @Focus from scenarios
* Update changelog.txt
* fix typo
* fix cucumber expression dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Cucumber expressions support
Types of changes
Checklist: