Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating PR 1614 #2582

Merged
merged 41 commits into from
May 5, 2022
Merged

Integrating PR 1614 #2582

merged 41 commits into from
May 5, 2022

Conversation

gasparnagy
Copy link
Contributor

This is a temporary PR for checking integration possibilities of #1614

NorekZ and others added 19 commits February 4, 2022 15:08
@NorekZ
TechTalk.SpecFlow project uses async/await all the way.
77454ae
@NorekZ
TechTalk.SpecFlow.Generator made use of async/await
19a52b4
@NorekZ
TechTalk.SpecFlow.xUnit.Generator.SpecFlowPlugin made use of async/await
17aab79
@NorekZ
Generation fixed
716958f
@NorekZ
TestProjectGenerator submodule updated
8f6ae1a
@NorekZ
Called method names fixed
be303a8
@NorekZ
Submodule updated & build fixed
54d71d2
@NorekZ
Test build fixed
d10fcaa 
Failing tests fixed
@NorekZ
Sync version of some interfaces returned to made VS extension working
801b62e
@NorekZ
Some missing awaits are now being generated
36252d5
@NorekZ
Wrong test run cleanup call removed
5e36b22 
Some tests fixed
@NorekZ
Merged from origin master
f62231e
@NorekZ
Build fixed
35ccdeb
@gasparnagy
Merge branch 'master' into pr/n1614_master
9da72f9 
* master:
  Specs: Make Specs easier filterable for target framework
  ExternalData: Make ScenarioTransformation more robust, fix unit tests
  Spec flow oss#2571 (#2578)
@gasparnagy
Fix ScenarioPartHelperTests for PR #1614
2afa355
@gasparnagy
Temporarily disable parallel execution for Specs
db98dd8
@gasparnagy
Fix NUnit.AssemblyHooks (not final), errors 35->31
fabdb9d
@gasparnagy
Fix NUnit async test generator, reconsider MarkCodeMemberMethodAsAsyn…
f812226 
…c, errors 31 -> 28
@gasparnagy
Fix MsTest async compilation errors
b7bb73f
@gasparnagy
Copy link
Contributor Author

Notes:

  • Shall we keep Steps.Given & co.? Shall we add Steps.GivenAsync (it is added now)? Shall we mark it as obsolete?

@gasparnagy gasparnagy mentioned this pull request Apr 13, 2022
Closed
7 tasks
@gasparnagy
Copy link
Contributor Author

Integration status:

TODO (after Easter):

  • Review and decide on TODOs
  • Manual exploratory testing
  • Check/fix VS integration (especially VS2022)

@gasparnagy
Copy link
Contributor Author

Green build! Hurray!

@gasparnagy
Remove dependency to Microsoft.Bcl.AsyncInterfaces to avoid conflicts
f998b06
@gasparnagy
Merge remote-tracking branch 'origin/master' into pr/n1614_master
f8fc446 
* origin/master:
  Corrected misspelled word (#2589)
  Expanded explanations about methods to create and compare objects (#2585)
  Support IReadOnlyCollection binding for ListValueRetriever (#2584)
  Use always .NET SDKs for building and running tests (#2583)

# Conflicts:
#	ExternalRepositories/SpecFlow.TestProjectGenerator
@gasparnagy
remove resolved TODO
1fd95ab
@gasparnagy
Copy link
Contributor Author

Status today:

  • Async behavior and backwards compatibility checked using manual exploratory testing (basic xUnit, MsTest, NUnit projects, compatibility check with a real project).
  • TODOs are removed

Notes:

  • I have removed the Microsoft.Bcl.AsyncInterfaces because we only used it for one class and it might cause versioning problems for .NET 4 (see here). The Microsoft.Bcl.AsyncInterfaces reference addition can be removed now from TestProjectGenerator, I think, but I haven't removed it yet.
  • Good news: SpecFlow.Plus.LivingDoc v3.9.57 seem to work fine with the new version (unused steps are also found correctly)
  • Bad news: VS2022 does not work, as expected

Next steps:

  • Merge PR
  • Fix VS2022 integration

//cc @SabotageAndi

@gasparnagy gasparnagy marked this pull request as ready for review May 2, 2022 12:48
SabotageAndi
SabotageAndi reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@SabotageAndi SabotageAndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the one HintPath, it looks good.
Please merge it only after I raised the version number in master to 3.10.

TechTalk.SpecFlow/TechTalk.SpecFlow.csproj Outdated Show resolved Hide resolved
@SabotageAndi
Copy link
Contributor

Master is bumped to 3.10-beta

@gasparnagy
Merge remote-tracking branch 'origin/master' into pr/n1614_master
cd1e25d 
* origin/master:
  version bump to 3.10-beta
  introduce a TraceListener for MSBuild Task (#2590)
@gasparnagy
small fixes
2cbc47c
@gasparnagy
Remove unused assembly reference
76d27a0
@SabotageAndi SabotageAndi merged commit 8b7eb2e into master May 5, 2022
@SabotageAndi SabotageAndi deleted the pr-1614 branch May 5, 2022 13:21
@JoshKeegan JoshKeegan mentioned this pull request May 20, 2022
Closed
Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
@gasparnagy @NorekZ @Code-Grump
Integrating PR 1614 (SpecFlowOSS#2582)
606abf9 
Co-authored-by: Norbert Žofák <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabotageAndi SabotageAndi SabotageAndi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gasparnagy @SabotageAndi @NorekZ