Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: @ignore tag check was looking for the wrong value #2572

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

JoshKeegan
Copy link
Contributor

Fixes a bug that has been introduced in the latest release as part of #2410 causing tests with an @ignore tag to still be run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@bollhals
Copy link
Contributor

bollhals commented Mar 14, 2022

Whooops, my bad. sometimes a good old copy paste is better than writing it yourself and making mistakes... Sorry about that.

Thanks for fixing it.

@SabotageAndi
Copy link
Contributor

Yes, thanks for fixing it @JoshKeegan

@SabotageAndi SabotageAndi reopened this Mar 15, 2022
@SabotageAndi SabotageAndi merged commit c2a0ed1 into SpecFlowOSS:master Mar 15, 2022
@SabotageAndi
Copy link
Contributor

Sorry, hit the wrong button.

Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants