Changed NUnit3TestGeneratorProvider.SetTestMethod() and NUnit3TestGeneratorProvider.SetRowTest() to virtual #2567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed NUnit3TestGeneratorProvider.SetTestMethod() and NUnit3TestGeneratorProvider.SetRowTest() to virtual. This will enable them to be overriden in generator plugins.
Why?
XUnit2TestGeneratorProvider has these methods virtual. This enables overriding but keeping the ability to invoke base methods' code.
This enables generator plugin devs to add additional functionality such as adding custom attributes during tag discovery in various situations (scenarios/scenario outlines/features/with tag/without tag).
NUnit3TestGeneratorProvider hasn't these methods virtual. Therefore, anyone who would want to override functionality, had to copy the entire NUnit3TestGeneratorProvider's body, and then add desired additional functionality. This could cause 3rd party generator plugins to be prone to updates in NUnit3TestGeneratorProvider class.
Types of changes
Checklist: