Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DateTimeStyles to DateTime(Offset)ValueRetriever #2565

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

bollhals
Copy link
Contributor

@bollhals bollhals commented Mar 9, 2022

This change adds a way to modify the DateTimeStyles used when parsing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@SabotageAndi
Copy link
Contributor

I like this idea.
Would you have some time to add a paragraph to https://github.com/SpecFlowOSS/SpecFlow/blob/master/docs/Bindings/Step-Argument-Conversions.md?

@bollhals
Copy link
Contributor Author

Sure, will update the docs and forward integrate 👍

@bollhals
Copy link
Contributor Author

I like this idea. Would you have some time to add a paragraph to https://github.com/SpecFlowOSS/SpecFlow/blob/master/docs/Bindings/Step-Argument-Conversions.md?

@SabotageAndi But this isn't used for Step-Argument-Conversions is-it? Should I add it to SpecFlow.Assist-Helpers?

@SabotageAndi
Copy link
Contributor

@bollhals You are completely right.

@bollhals
Copy link
Contributor Author

Can you check if the doc is fine for you?

@SabotageAndi
Copy link
Contributor

Perfect @bollhals!

@SabotageAndi SabotageAndi merged commit 6831478 into SpecFlowOSS:master Mar 14, 2022
@bollhals bollhals deleted the feature/DateTimeStyles branch March 14, 2022 13:26
Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants