Crash when using Autofac Plugin with injection to a static methods

[HotTaton]

Crash when using dependency injection in static methods (i.e. hooks marked AfterFeature attribute)

SpecFlow Version:

• 3.6
• 3.5
• 3.4
• 3.3
• 3.1
• 3.0
• 2.4
• 2.3
• 2.2
• 2.1
• 2.0
• 1.9

Used Test Runner

• SpecFlow+Runner
• MSTest
• NUnit
• Xunit

Version number:

Project Format of the SpecFlow project

• Classic project format using packages.config
• Classic project format using <PackageReference> tags
• Sdk-style project format

.feature.cs files are generated using

• SpecFlow.Tools.MsBuild.Generation NuGet package
• SpecFlowSingleFileGenerator custom tool

Visual Studio Version

• VS 2019
• VS 2017

Enable SpecFlowSingleFileGenerator Custom Tool option in Visual Studio extension settings

• Enabled
• Disabled

Are the latest Visual Studio updates installed?

• Yes
• No, I use Visual Studio version <Major>.<Minor>.<Patch>

.NET Framework:

• >= .NET 4.5
• before .NET 4.5
• .NET Core 2.0
• .NET Core 2.1
• .NET Core 2.2
• .NET Core 3.0
• .NET Core 3.1
• .NET 5.0

Test Execution Method:

• Visual Studio Test Explorer
• TFS/VSTS/Azure DevOps – Task – PLEASE SPECIFY THE NAME OF THE TASK
• Command line – PLEASE SPECIFY THE FULL COMMAND LINE

<SpecFlow> Section in app.config or content of specflow.json

Issue Description

Crash when using dependency injection in static methods (i.e. hooks marked AfterFeature attribute).
Autofac container created for Scenario and when time comes to resolve injection in static method it is already disposed.

Steps to Reproduce

You can reproduce it with creating hook with code below:

[AfterFeature]
public static void AfterFeature(FeatureContext featureContext)
{
    var item = some.FeatureInfo;
}

[HotTaton]

Code below can solve some cases (injecting FeatureContext for example, but it not cover all scenarios. I think maybe we need a new attribute, FeatureDependencies (with logic like in ScenarioDependencies) or something like that.
I can contribute code below if all good, or I can help with resolving problem generally.

public class AutofacTestObjectResolver : ITestObjectResolver
    {
        public object ResolveBindingInstance(Type bindingType, IObjectContainer scenarioContainer)
        {
            if (scenarioContainer.IsRegistered<IComponentContext>())
            {
                var componentContext = scenarioContainer.Resolve<IComponentContext>();
                return componentContext.Resolve(bindingType);
            }
            return scenarioContainer.Resolve(bindingType);
        }
    }

Thanks.

[SabotageAndi]

Ah, yes, that is a problem.
We want to resolve the FeatureContext from the Autofac container, which doesn't work because it is not registered there.

If you could provide a PR with a fix for it, that would be awesome and probably the quickest way to get it fixed.
As we are only a small team, it will probably take some time until we get to this issue.

If you need help, you can join the #contributing channel on our discord server (https://go.specflow.org/join-contributing-on-discord).

[SabotageAndi]

Fixed with #2315

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.