Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow QueuedExport to serialize query builder (to array) using laravie/serializes-queries #99

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

crynobone
Copy link
Contributor

As discussed on Twitter.

Also Reflexecute (on Discord) helped me test the code locally and VPS.

Screenshot 2020-10-03 at 10 14 46 PM

@patrickbrouwers
Copy link
Member

Thanks @crynobone !

@rickgoemans
Copy link

Reflexecute here (see the matching profile photo), I confirm the new queued export works perfectly (tested on Laravel 7 with PHP 7.3 and Laravel 8 with PHP 7.4).

As stated in the discord chat history, I don't know why the VPS took so long but our end customer runs multiple projects on the same VPS and the configuration might not be the fastest anyway (since it took almost x3 of execution time even at like 11 PM when there shouldn't be any load at all).

I hope this get's merged because it saves a lot of hassle manually creating a queued implementation yourself!

@patrickbrouwers patrickbrouwers merged commit 285cdff into SpartnerNL:1.2 Oct 8, 2020
@patrickbrouwers
Copy link
Member

Thanks again @crynobone and thanks @rickgoemans for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants