Skip to content

Commit

Permalink
Allow new version of maatwebsite/excel again to support laravel 7 + m…
Browse files Browse the repository at this point in the history
…ark queued exports as deprecated
  • Loading branch information
patrickbrouwers committed Feb 28, 2020
1 parent 2e1e5f3 commit d3c17f7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"require": {
"php": ">=7.1.0",
"laravel/nova": "*",
"maatwebsite/excel": "3.1.17"
"maatwebsite/excel": "^3.1"
},
"autoload": {
"psr-4": {
Expand Down
5 changes: 4 additions & 1 deletion src/Actions/QueuedExport.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
use Laravel\Nova\Nova;
use Maatwebsite\LaravelNovaExcel\Requests\SerializedRequest;

/**
* @deprecated It's currently impossible to queue an export based on dynamic filters due to serialization issues of the query.
*/
class QueuedExport extends ExportToExcel implements ShouldQueue
{
/**
Expand Down Expand Up @@ -39,7 +42,7 @@ public function __wakeup()
}

/**
* @var string
* @return string
*/
public function name()
{
Expand Down

0 comments on commit d3c17f7

Please sign in to comment.