Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make progress bar redirect to nullOutput if not provided #3032

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

ahmedsayedabdelsalam
Copy link
Contributor

return nullOutput if not set instead of throwing error to use method ->withOutput() because sometimes I need to call the excel from Action as a (command) or as a (job, object) and the current implementation make it mandatory to pass the OutputStype class even if I run it as a job

image

@patrickbrouwers patrickbrouwers merged commit 12e1574 into SpartnerNL:3.1 Feb 17, 2021
@patrickbrouwers
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants