BREAKING!!! Migrate to puppeteer.defaultArgs() #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing them in this package
browser = await puppeteer.launch({
- args: chromium.args,
+ args: puppeteer.defaultArgs({
+ args: chromium.args,
+ }),
* master: 126.0.0 don't disable the graphics stack #247 update to chromium 126 ignore internal docker folder update deps
|
It seems like this should just work with Playwright as they don't replace the args, they merge them. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, dropping chromium.headless.
Lint and cleanup
TODO: