Validate type of recipients #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richleland
suggested changes
Mar 6, 2017
test/test_transmissions.py
Outdated
| @@ -28,6 +28,19 @@ def test_translate_keys_with_recips(): | |||
| {'key': 'value'}, | |||
| {'address': {'email': 'foobar'}}] | |||
|
|
|||
| results = t._translate_keys( | |||
There was a problem hiding this comment.
what is this testing differently than the above?
There was a problem hiding this comment.
just wanted to test a different data structure but looks like redundant. i've removed it.
sparkpost/transmissions.py
Outdated
| @@ -137,6 +138,10 @@ def _parse_address(self, address): | |||
| return parsed_address | |||
|
|
|||
| def _extract_recipients(self, recipients): | |||
|
|
|||
| if not (isinstance(recipients, list) or isinstance(recipients, dict)): | |||
There was a problem hiding this comment.
You can pass a tuple as the second argument to isinstance like so:
isinstance(recipients, (list, dict))
|
@richleland done with requested changes |
richleland
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #138