Adds probes to the controler and liveness probe to the env-injector #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition this was tested on an AKS cluster on which the probes succeeded. |
For some reason this didn't show up like this in my editor, so I used the github editor to fix it.
|
Can someone take a look at this PR? |
|
@LennartTimmers Thank you very much |
|
@LennartTimmers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #97
This PR adds probes to the pods that run using the existing /healthz endpoint for both the env-injector and the controller. The env-injector already had a readiness probe so only the liveness probe was added, the controller didn't have either so I've added both.
Let me know if I need to make additional changes to comply with your pull request standards!
Kind regards,
Lennart