Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use registry authentication for azure sp credentials, when authType i… #631

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Use registry authentication for azure sp credentials, when authType i… #631

merged 6 commits into from
Nov 12, 2023

Conversation

abhilashjoseph
Copy link
Contributor

@abhilashjoseph abhilashjoseph commented Nov 2, 2023 •
edited
Loading

…s azureCloudConfig

Motivation

Approach

  • Authenticate with service principal credential inaddition to imagepull secret when azure cloud configuration is used.
  • Update enviroment var akvs name to match rfc1123 for dns label names used for kubernetes resource names. inccrease allowed regex chars to 253

@abhilashjoseph abhilashjoseph mentioned this pull request Nov 3, 2023
Open
181192
181192 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@181192 181192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhilashjoseph Fantastic, thank you! ☺️

@181192 181192 merged commit baaa950 into SparebankenVest:master Nov 12, 2023
1 check passed
This was referenced Nov 12, 2023
Closed
Closed
@pyrxm pyrxm mentioned this pull request Jan 5, 2024
Open
@Tabrnicus Tabrnicus mentioned this pull request Jan 9, 2024
Open
pyrxm added a commit to pyrxm/azure-key-vault-to-kubernetes that referenced this pull request Jan 18, 2024
@pyrxm
Revert "Merge pull request SparebankenVest#631 from abhilashjoseph/ma…
0a5947a 
…ster"

This reverts commit baaa950, reversing
changes made to ffbc2f5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspearconquest tspearconquest tspearconquest left review comments

@181192 181192 181192 approved these changes

@torresdal torresdal Awaiting requested review from torresdal torresdal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhilashjoseph @181192 @tspearconquest