Do not mutate pod spec security context #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspearconquest
force-pushed
the
do_not_mutate_pod_spec_security_context
branch
from
40ebbe5 to
7141e5f
Compare
…mutating the pod spec (which affects containers other than its own and overwrites what a user, administrator, or another webhook may have set) Signed-off-by: Thomas Spear <[email protected]>
181192
approved these changes
Aug 28, 2023
Do you have an eta for new (patch) release? |
|
Hi @181192 we need this turned into a 1.5.1 release please. |
|
@tspearconquest @HammerNL89 I have added a pre-release 1.5.1-beta.1 |
Thanks, do you have an eta for a non beta version (1.5.1) release? We can't use beta versions. This would help us decide whether or not we revert to a previous version of akv2k8s or wait for the new release. |
|
the over-writing of pod security context is fairly problematic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591