feat: add support for Workload Identity #443
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Workload Identity.
Implementation details
UseManagedIdentityExtension
, so I thought it would make sense to haveUseWorkloadIdentityExtension
then;Tests
Terraform lab with instructions is shared here: https://github.com/weisdd/akv2k8s-pr-443
Potential TODO
Another PR for the same functionality
Aside from a tiny fix for ACR credentials, the rest of the code was prepared last Saturday, just didn't have time to properly test it throughout the week due to excessive load at work. And it happened that another PR was raised today #442 before I did mine. - It tries to achieve the same goal, but under the existing
UseManagedIdentityExtension
flag and without precautions for adal tokens. Though, in the end, the only important thing is to have the functionality implemented, so I don't mind if my PR gets closed in favour of that one.Closes: #378