Authentication service secret efficiency change #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
181192
requested changes
Dec 8, 2022
181192
approved these changes
Dec 8, 2022
|
Thank you very much @waterfoul released webhook image 1.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the creation of the authentication service secret out of mutate containers. Before it was attempting to create an identical secret for each container and init container. The end result was a single secret but there was quite a bit of time spent spinning over the containers checking to see if the secret (which was already created) was there. This change moves it outside mutateContainers resulting in a single attempt instead of container count + init container count attempts.
Ex. If you have 5 containers and 3 init containers it would try 7 times before, it now does it once.
In our cluster this was causing the webhook to timeout on a large pod with many containers