Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one_hot_water not implemented? #43

Closed
ckohrt opened this issue Mar 6, 2021 · 9 comments
Closed

one_hot_water not implemented? #43

ckohrt opened this issue Mar 6, 2021 · 9 comments

Comments

@ckohrt
Copy link

ckohrt commented Mar 6, 2021

Hi! Thanks for your great work!

I tried to srite a value to one_hot_water but received the answer
root> pyHPSU.py -c one_hot_water:1 -d PYCAN -p /dev/ttyS0
error - type "value" not implemented since yet

Is it planned to be implemented?

Cheers
Christian

@ckohrt
Copy link
Author

ckohrt commented Mar 6, 2021

Ok, I may have solved it by myself. I have changed the part for one_hot_water in the commands_hpsu.json from:
"one_hot_water" : {
"name" : "one_hot_water",
"command" : "31 00 FA 01 44 00 00",
"id" : "190",
"divisor" : "1",
"writable" : "true",
"unit" : "longint",
"type" : "value",
"value_code" : {
"0" : "off",
"1" : "on"
}
to:
"one_hot_water" : {
"name" : "one_hot_water",
"command" : "31 00 FA 01 44 00 00",
"id" : "190",
"divisor" : "1",
"writable" : "true",
"unit" : "longint",
"type" : "longint",
"value_code" : {
"0" : "off",
"1" : "on"
}

Can somebody with more experiance than me check it and change it in the code please?

@segaura
Copy link

segaura commented Mar 7, 2021

Hi! Thanks for your great work!

I tried to srite a value to one_hot_water but received the answer
root> pyHPSU.py -c one_hot_water:1 -d PYCAN -p /dev/ttyS0
error - type "value" not implemented since yet

Is it planned to be implemented?

Cheers
Christian

I think the general request ultimately relates to this kind of improvements

@ckohrt
Copy link
Author

ckohrt commented Mar 7, 2021

#45

@Spanni26
Copy link
Owner

Spanni26 commented Mar 7, 2021 via email

@ckohrt
Copy link
Author

ckohrt commented Mar 7, 2021

Hi Daniel,
I will never ever set one_hot_water to "0", because

  1. the pump SHALL do one time hot water generation up to the defined temperature and stops automatically.
  2. this is not possible from the Daikin Control GUI
    There is just no reason to do so. Maybe the pump just doesn't accept "0".

@ckohrt
Copy link
Author

ckohrt commented Mar 7, 2021

from my side we can clode this issue

@ckohrt ckohrt closed this as completed Mar 7, 2021
@ckohrt ckohrt reopened this Mar 7, 2021
@ckohrt
Copy link
Author

ckohrt commented Mar 7, 2021

just in case somebody thinks that this is working. I tried it today in my automation system. Result: mode was set to 4 but I have no evidence that it really did hot water.... So I check tomorrow again.

@ckohrt
Copy link
Author

ckohrt commented Mar 8, 2021

I checked the new implementation - it works! Thanks!

@ckohrt ckohrt closed this as completed Mar 8, 2021
@ckohrt
Copy link
Author

ckohrt commented Mar 8, 2021

Hi! Thanks for your great work!
I tried to srite a value to one_hot_water but received the answer
root> pyHPSU.py -c one_hot_water:1 -d PYCAN -p /dev/ttyS0
error - type "value" not implemented since yet
Is it planned to be implemented?
Cheers
Christian

I think the general request ultimately relates to this kind of improvements

thanks for linking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants