Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong icon when building on MacOS #18

Closed
Itai-Nelken opened this issue Feb 15, 2021 · 3 comments
Closed

wrong icon when building on MacOS #18

Itai-Nelken opened this issue Feb 15, 2021 · 3 comments
Labels
type:feat New feature or request

Comments

@Itai-Nelken
Copy link
Contributor

I built the app on MacOS (for fun, I don't really need it so it doesn't really matter if its fixed or not) with

npm i && npm run make

that resulted with a zip with the .app inside as it should, but the .app's icon is the electron icon, not the discord one:
Screen Shot 2021-02-15 at 5 49 48 PM
@SpacingBat3
Copy link
Owner

You're buiding it for the MacOS, right?
Sorry, I haven't implemented much changes for the MacOS, and this might be why this icon looks like this...
I believe there's some keys for that to set in my JSON config.

AFAIK this issue is meant to be the case for the Windows as well, but the same fix can be done for that...

Actually might fix that issue... AFAIK Electron supports now the Apple M1 (MacOS ARM), which is why this might be needed for someone... but I don't think I will ever provide any of the releases for MacOS or Windows, no matter if it is installed on the X86 nor ARM hardware.

@SpacingBat3 SpacingBat3 self-assigned this Feb 15, 2021
@SpacingBat3 SpacingBat3 added type:feat New feature or request good first issue Good for newcomers labels Feb 15, 2021
@Itai-Nelken
Copy link
Contributor Author

I'm building it for MacOS on MacOS.

as I said, I'm doing it for fun, anyone on MacOS will probably just use the official app.

@Itai-Nelken Itai-Nelken mentioned this issue Feb 15, 2021
Closed
SpacingBat3 added a commit that referenced this issue Feb 15, 2021
@SpacingBat3
Some minior fixes.
fa69d3e 
- Fixed (#18) and (#19) issues.
  - Added the icons for the MacOS/Windows builds.
- Some syntax changes.
- Copyright year isn't updated automatically based on the current year from now.
- Splitted electron-forge configuration lines to the new JavaScript file.
- Moved the application documentation to the "docs/" folder.
- Improved building on Linux hosts (with additional BASH script).
SpacingBat3 added a commit that referenced this issue Feb 15, 2021
@SpacingBat3
Some minior fixes.
f1717ad 
- Fixed (#18) and (#19) issues.
  - Added the icons for the MacOS/Windows builds.
- Some syntax changes.
- Copyright year isn't updated automatically based on the current year from now.
- Splitted electron-forge configuration lines to the new JavaScript file.
- Moved the application documentation to the "docs/" folder.
- Improved building on Linux hosts (with additional BASH script).
@SpacingBat3
Copy link
Owner

Improved in the commit: f1717ad

@SpacingBat3 SpacingBat3 removed the good first issue Good for newcomers label Feb 15, 2021
SpacingBat3 added a commit that referenced this issue Feb 18, 2021
@SpacingBat3
Merge from 1.0.x (#27)
0a00e8a 
* Some minior fixes.

- Fixed (#18) and (#19) issues.
  - Added the icons for the MacOS/Windows builds.
- Some syntax changes.
- Copyright year isn't updated automatically based on the current year from now.
- Splitted electron-forge configuration lines to the new JavaScript file.
- Moved the application documentation to the "docs/" folder.
- Improved building on Linux hosts (with additional BASH script).

* Fixed the bug in spellchecker (#22).

* Improved DEB build in the forge config.
@SpacingBat3 SpacingBat3 removed their assignment Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feat New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpacingBat3 @Itai-Nelken