Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update celery versions #161

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Update celery versions #161

merged 1 commit into from
Oct 1, 2024

Conversation

nyandika
Copy link
Contributor

Description

Was getting a cannot import name 'Celery' from 'celery' error while trying to build the code
Similar to discussion here: python/importlib_metadata#411

Updating the libraries involved unblocked me

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

CI Django & Postgres Tests

Jambo

Test Configuration:

          python manage.py migrate
          python manage.py test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Contributor,👋👋 Thank You For Opening This Pull Request 🎉🎉

Welcome to SpaceYaTech

We are the fastest growing Africa Open-Source Community Looking To Change The Way Young Africans Get Started In Technology.

JOIN US | THRIVE | GROW

SpaceYaTech Server
SpaceYaTech LinkedIn
SpaceYaTech Twitter
Website

It's great having you contribute to this project

Welcome to the community 🤓 🍿 **Fun facts** - we eat bugs 🐛🐛🐛🐛 for breakfast 🥣

This Pull request has been queued for `review`

Sit tight the maintainers are on your case.

Soon the maintainers/owner will review it and provide you with feedback suggestions.
If you think it's something urgent, feel free to reach out

Copy link
Member

@JimmyTron JimmyTron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces necessary updates to resolve an issue encountered during the build process. After reviewing the changes and understanding the reasoning, I approve it with the following observations:

Celery upgrade: The version bump from 5.2.7 to 5.4.0 was necessary to resolve an import error (cannot import name 'Celery' from 'celery'), similar to the issue discussed in python/importlib_metadata#411. Updating to the latest version unblocked the build process. While this fix is important, thorough testing is still recommended to ensure compatibility with the task processing workflows.

Kombu upgrade: With Kombu being closely tied to Celery for message passing, the version upgrade from 5.2.4 to 5.4.2 ensures better compatibility with the updated Celery version. It's crucial to review the Kombu changelog and verify no breaking changes affect task queueing behavior.

Timezone data update: The update of tzdata to version 2024.2 ensures that the project is using the latest timezone information, which is particularly important for applications dealing with scheduling and international time zones.

The updates address a critical issue and bring the dependencies up to date. I recommend testing the changes thoroughly in a staging environment to confirm the system's stability and functionality before deploying to production.

Great job!

@JosephThuku
Copy link

Did you confirm that the updated dependencies are compatible with Python 3.10, which is used to build the application? Compatibility checks are crucial to ensure stability and functionality?

@nyandika
Copy link
Contributor Author

nyandika commented Oct 1, 2024

This workflow that runs against pull requests and merges to main is set up with Python 3.10.

This successful actions build against the PR implies compatibility

@JosephThuku
Copy link

I agree 💯

@JimmyTron JimmyTron added this pull request to the merge queue Oct 1, 2024
Merged via the queue into SpaceyaTech:main with commit d60df09 Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants