Added example to membership_plans. Fixes #16 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
requested changes
Mar 29, 2018
CHANGELOG.md
Outdated
| @@ -15,3 +15,4 @@ Changes should start with one of the following tags: | |||
| - [added] The `timezone` key was added under `location` | |||
| - [added] The `membership_plans` key was added to represent membership plans a space might have | |||
| - [changed] The unit `hPA` in `sensors.barometer.unit` was renamed to `hPa` to match the SI unit | |||
| - [changed] An example was added to the description of the `membership_plans` | |||
There was a problem hiding this comment.
I think we can leave out changes that don't affect users :)
14-draft.json
Outdated
| @@ -1153,7 +1153,7 @@ | |||
| "type": "string" | |||
| }, | |||
| "renewal_interval": { | |||
| "description": "How often is the membership renewed? If you select other, please specify in the description what your renewal interval is.", | |||
| "description": "How often is the membership renewed (billed)? If you select other, please specify in the description what your renewal interval is.", | |||
There was a problem hiding this comment.
Hm, that's actually a good point. Renewal isn't the best term to use. What about changing the key to billing_interval?
14-draft.json
Outdated
| @@ -1135,7 +1135,7 @@ | |||
| } | |||
| }, | |||
| "membership_plans": { | |||
| "description": "A list of the different membership plans your hackerspace might have.", | |||
| "description": "A list of the different membership plans your hackerspace might have. Try to use the minimal amount of information needed to describe the membership plan. For example, if your membership fee is 10€ per month, but you bill it yearly (aka. the member pays the fee once per year), set the amount to 120 an the renewal_interval to yearly.", | |||
There was a problem hiding this comment.
I'm not yet convinced of the second sentence. What about changing it to something like "Set the value according to your billing process."?
|
Added the requested changes |
dbrgn
approved these changes
Mar 30, 2018
gidsi
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.