Add gopher url #24
Closed
Add gopher url #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Gopher is a fast-growing emerging technology, I find it important that a space can also show his representation in the gopher space on the space API
dbrgn
approved these changes
Jan 31, 2018
gidsi
reviewed
Feb 6, 2018
|
I guess with the url array would really be the better solution |
Changing the URL from a string to an array would be a breaking change. (Also in practice the url field means website over http in most of the cases and is not used for any other protocol) |
|
I think gopher fits in well alongside twitter and google+. |
rnestler
requested changes
Feb 7, 2018
| @@ -264,6 +264,10 @@ | |||
| "issue_mail": { | |||
| "description": "A separate email address for issue reports (see the <em>issue_report_channels</em> field). This value can be Base64-encoded.", | |||
| "type": "string" | |||
| }, | |||
| "gopher": { | |||
| "description": "A url to find information about the Space in the Gopherspace.", | |||
There was a problem hiding this comment.
Spelling: "A URL"
Also maybe add an explicit example like: gopher://whatever
|
Ping @PhilmacFLy, do you plan to implement a fix for the suggestion by @rnestler? |
|
Ping @PhilmacFLy again 🙂 |
|
Sorry must have missed the suggestion aswell as the first ping. Yes I will do a fix for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Gopher is a fast-growing emerging technology, I find it important that a space can also show his representation in the gopher space on the space API