Removed enum in sensors.account_balance. Fixes #5 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
requested changes
Feb 5, 2017
CHANGELOG.md
Outdated
| @@ -9,4 +9,4 @@ Changes should start with one of the following tags: | |||
|
|
|||
| ## v0.14 (unreleased) | |||
|
|
|||
| - ... | |||
| - [changed] Removed `enum` in `sensors.account_balance` | |||
There was a problem hiding this comment.
Maybe reword this to:
[changed] The value in `sensors.account_balance` can now be any ISO 4217 string
14-draft.json
Outdated
| "USD", | ||
| "GBP" | ||
| ] | ||
| "description": "What's the currency? It should be formated according to <a href=\"http://de.wikipedia.org/wiki/ISO_4217\" target=\"_blank\">ISO 4217</a> short-code format.", |
There was a problem hiding this comment.
Could you make the link post to the English Wikipedia, and use https?
|
I've updated to all proposed changes |
dbrgn
requested changes
Feb 6, 2017
14-draft.json
Outdated
| "USD", | ||
| "GBP" | ||
| ] | ||
| "description": "What's the currency? It should be formated according to <a href=\"https://en.wikipedia.org/wiki/ISO_4217\" target=\"_blank\">ISO 4217</a> short-code format.", |
There was a problem hiding this comment.
Found another typo, formated should be formatted :)
|
Done all the change requests! |
dbrgn
approved these changes
Feb 6, 2017
|
Thank you! |
dbrgn
pushed a commit
that referenced
this pull request
Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.