Add areas to location #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SpaceApi/core if I understood you correctly during today's meeting, this was the proposal that we converged on. Do you agree with that? (The old PR was still against schema v14-draft, btw 😂) |
Closed
This key can be used to specify a list of areas that make up your physical location. Each area has a required size (in square meters), and an optional name and description.
|
@dbrgn Whats holding the merge back? |
4 hours ago, it was the missing second review 😂 Once you added your review, you could have hit the "merge" button. |
Ah I think we agreed that 1 review is enough if the change comes from a core member anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This key can be used to specify a list of areas that make up your physical location. Each area has a required size (in square meters), and an optional name and description.
Replaces #71. (See discussion in that MR for context.)