Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DaService method extract_relevant_txs to extract_relevant_blobs #977

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

dubbelosix
Copy link
Contributor

Description

  • Renaming the following functions
  • extract_relevant_txs to extract_relevant_blobs
  • extract_relevant_txs_with_proof to extract_relevant_blobs_with_proof

The reason for this rename is to make a clearer distinction in the naming so that developers know this refers to DA blob transactions and not the rollup transactions

Linked Issues

@dubbelosix dubbelosix marked this pull request as ready for review October 3, 2023 11:05
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #977 (bf67df7) into nightly (baebd03) will not change coverage.
The diff coverage is 40.0%.

Files Coverage Δ
full-node/sov-stf-runner/src/runner.rs 75.4% <100.0%> (ø)
rollup-interface/src/state_machine/mocks/da.rs 79.8% <100.0%> (ø)
adapters/celestia/src/da_service.rs 62.3% <0.0%> (ø)
rollup-interface/src/node/services/da.rs 0.0% <0.0%> (ø)

@dubbelosix dubbelosix added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 3, 2023
@dubbelosix dubbelosix added this pull request to the merge queue Oct 4, 2023
Merged via the queue into nightly with commit 306dc1f Oct 4, 2023
@dubbelosix dubbelosix deleted the dub/minor_rename branch October 4, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename DaService method extract_relevant_txs to extract_relevant_blobs
2 participants