Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish cargo doc assets to GH pages #468

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Publish cargo doc assets to GH pages #468

merged 1 commit into from
Jul 7, 2023

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Jul 6, 2023

Description

As we add more doc comments to our crates, it'd be nice to have up-to-date Cargo docs hosted somewhere. I'm adding 2 steps to our CI, one to build the docs and one to upload them to GH Pages.

@neysofu neysofu marked this pull request as ready for review July 6, 2023 13:44
Copy link
Member

@cemozerr cemozerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for testing reasons.

@neysofu neysofu changed the title WIP: publish cargo doc on GH pages Publish cargo doc assets to GH pages Jul 6, 2023
@neysofu
Copy link
Member Author

neysofu commented Jul 6, 2023

Alright, the PR is ready for approval. CI is failing because only main is allowed to deploy to GH Pages. I expect it to work after merging; in case of issues I'll open another PR immediately with the necessary fixes.

@neysofu neysofu requested a review from citizen-stig July 6, 2023 14:22
@neysofu neysofu merged commit 8e4cc3e into main Jul 7, 2023
@neysofu neysofu deleted the filippo/docs branch July 7, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants