-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sov-cli
can submit transactions to sov-sequencer
and can trigger publishing batch
#446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizen-stig
force-pushed
the
feature/sov_submit_call
branch
2 times, most recently
from
June 29, 2023 12:11
6cbec63
to
c8057fb
Compare
Codecov Report
|
citizen-stig
force-pushed
the
feature/sov_submit_call
branch
2 times, most recently
from
July 6, 2023 13:26
c4e50c0
to
fe3dd3e
Compare
citizen-stig
changed the title
Feature/sov submit call
Jul 7, 2023
sov-cli
can submit transactions to sov-sequencer
and can trigger publishing batch
bkolad
reviewed
Jul 7, 2023
bkolad
reviewed
Jul 7, 2023
citizen-stig
had a problem deploying
to
github-pages
July 7, 2023 12:45 — with
GitHub Actions
Failure
bkolad
reviewed
Jul 7, 2023
bkolad
approved these changes
Jul 7, 2023
citizen-stig
force-pushed
the
feature/sov_submit_call
branch
from
July 7, 2023 14:49
0d1d401
to
35ce413
Compare
citizen-stig
had a problem deploying
to
github-pages
July 7, 2023 15:01 — with
GitHub Actions
Failure
citizen-stig
had a problem deploying
to
github-pages
July 7, 2023 15:14 — with
GitHub Actions
Failure
citizen-stig
had a problem deploying
to
github-pages
July 7, 2023 15:47 — with
GitHub Actions
Failure
dubbelosix
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
submit_tx
andpublish_batch
borsh
state.submitPayForBlob
celestia endpointLinked Issues
Testing
Automated tests added, including mocking responses from Celestia node
Docs
Demo rollup documentation has been updated, as incorrect private key was used in Makefile, that lead to transfer and mint transactions were unusable because of different token address
Following work
This pull request offloaded many detected issues:
request_timeout
forCelestiaAdapter
#478anyhow::Error
withthiserror::Error
as return type in Celestia adapter and other libraries #473async_trait
for DaService #472CelestiaAddress
to fixFrom<[u8; 32]>
#469SequencerOutcome
should have generic over address trait for better logging #465