Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sov-cli can submit transactions to sov-sequencer and can trigger publishing batch #446

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented Jun 28, 2023

Description

  • Introduces 2 new sov-cli commands: submit_tx and publish_batch
  • Fixes batch serialization from flattening to using borsh
  • Fixes parameters for state.submitPayForBlob celestia endpoint
  • Fixes address display for celestia
  • Using Same celestia address that is used by RPC node
  • Celestia adapter handles errors better

Linked Issues

Testing

Automated tests added, including mocking responses from Celestia node

Docs

Demo rollup documentation has been updated, as incorrect private key was used in Makefile, that lead to transfer and mint transactions were unusable because of different token address

Following work

This pull request offloaded many detected issues:

@citizen-stig citizen-stig self-assigned this Jun 28, 2023
@citizen-stig citizen-stig force-pushed the feature/sov_submit_call branch 2 times, most recently from 6cbec63 to c8057fb Compare June 29, 2023 12:11
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #446 (0d1d401) into main (369d639) will increase coverage by 1.0%.
The diff coverage is 92.3%.

❗ Current head 0d1d401 differs from pull request most recent head c1ff9f7. Consider uploading reports for the commit c1ff9f7 to get more accurate results

Impacted Files Coverage Δ
...ystem/sov-modules-stf-template/src/app_template.rs 81.8% <0.0%> (-0.9%) ⬇️
module-system/sov-modules-stf-template/src/lib.rs 97.4% <ø> (ø)
full-node/sov-sequencer/src/lib.rs 78.1% <62.5%> (-2.3%) ⬇️
adapters/celestia/src/verifier/address.rs 74.3% <88.8%> (+74.3%) ⬆️
adapters/celestia/src/da_service.rs 62.0% <97.0%> (+48.3%) ⬆️

... and 2 files with indirect coverage changes

@citizen-stig citizen-stig force-pushed the feature/sov_submit_call branch 2 times, most recently from c4e50c0 to fe3dd3e Compare July 6, 2023 13:26
@citizen-stig citizen-stig changed the title Feature/sov submit call sov-cli can submit transactions to sov-sequencer and can trigger publishing batch Jul 7, 2023
@citizen-stig citizen-stig marked this pull request as ready for review July 7, 2023 12:35
Copy link
Contributor

@dubbelosix dubbelosix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@citizen-stig citizen-stig merged commit e542d7e into main Jul 10, 2023
@citizen-stig citizen-stig deleted the feature/sov_submit_call branch July 10, 2023 07:23
@citizen-stig citizen-stig linked an issue Jul 11, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Based Sequencing Feature
3 participants