Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy fixes after alpha release #392

Merged
merged 7 commits into from
Jun 7, 2023
Merged

Conversation

citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented Jun 6, 2023

Description

In order to unblock developers to use cargo clippy current issues needs to be addressed. This PR solves that.
After it is merged, everybody can use make lint which will do cargo check and cargo clippy for all targets and features.

As for now, clippy checks are optional and not part of CI

Testing

No tests should be affected

Docs

No changes in documentatio is needed

@citizen-stig citizen-stig self-assigned this Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

@citizen-stig citizen-stig force-pushed the chores/after_alpha_clippy_fixes branch from 00cd9aa to 36c977b Compare June 7, 2023 09:13
@citizen-stig citizen-stig marked this pull request as ready for review June 7, 2023 09:13
Copy link
Member

@preston-evans98 preston-evans98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@citizen-stig citizen-stig merged commit 256e238 into main Jun 7, 2023
@citizen-stig citizen-stig deleted the chores/after_alpha_clippy_fixes branch June 7, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants